sundeep8967 commented on PR #72288: URL: https://github.com/apache/airflow/pull/72288#issuecomment-5558847084
Thanks for the thorough review @hussein-awala! You're completely right — `Role.permissions` uses `lazy="joined"`, so SQLAlchemy requires `unique()` before consuming the result. I have updated the PR to: 1. Revert the changes to `roles.py` and `override.py`, keeping `.unique()` intact on all `Role` queries with joined eager loading. 2. Retain the cleanup on `FABAuthManagerUsers.get_users()` in `users.py`, where `User.roles` uses `lazy="selectin"`. 3. Updated the unit test in `test_users.py` to mock `scalars().all()` directly without `.unique()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
