saitejabandaru-in commented on PR #71840: URL: https://github.com/apache/airflow/pull/71840#issuecomment-5561903138
@moomindani Thank you for catching those test failures and for the great suggestions! I have: 1. Replaced all 28 references of `adatabricks_conn` with `_get_conn_async` in the test suite and updated the mock patch targets. 2. Renamed the cache attribute from `_adatabricks_conn` to `_conn_async_cache` in both the hook and the tests for consistency. 3. Updated the sync `_get_required_client_id` to raise `ValueError` so it matches the async twin exactly, and the sync test now correctly expects this narrower exception. 4. Added a test `test_get_conn_async` to explicitly cover the new `get_async_connection` compat path and verify connection caching. 5. Refactored `_a_get_token` and `_a_do_api_call` to await `_get_conn_async` just once per invocation and pass the resolved `conn` down, completely eliminating the duplicate method calls you mentioned. Everything should be perfectly aligned now! Thanks again for the meticulous review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
