sokojh opened a new pull request, #72609:
URL: https://github.com/apache/airflow/pull/72609
### Why
`providers/amazon/.../executors/batch/boto_schema.py` is on the
`OVERLOOKED_TESTS`
allowlist in `airflow-core/tests/unit/always/test_project_structure.py`,
tracked by
the meta issue #35442.
Unlike most entries on that list, the three schemas in this module are not
covered
indirectly either — no file under any `providers/*/tests/` directory
references
`BatchSubmitJobResponseSchema`, `BatchJobDetailSchema` or
`BatchDescribeJobsResponseSchema`. (For contrast, `build_submit_kwargs` in
the
sibling `batch_executor_config.py` *is* exercised from
`test_batch_executor.py`,
which is why this PR is scoped to `boto_schema.py` alone.)
These schemas parse live AWS Batch API responses, so the behaviour worth
pinning
down is the part that is easy to break silently: the `data_key` mapping from
the
API's camelCase to Airflow's snake_case, the `unknown = EXCLUDE` policy that
lets
the schemas tolerate fields AWS adds over time, and the `@post_load` hook
that
makes `BatchJobDetailSchema` return a `BatchJob` rather than a plain dict.
### How
Adds
`providers/amazon/tests/unit/amazon/aws/executors/batch/test_boto_schema.py`
with one test class per schema, covering for each:
- the happy-path load and the `jobId` → `job_id` renaming,
- that unknown keys returned by `submit_job` / `describe_jobs` are dropped
rather
than raising,
- that a missing required field raises `ValidationError`,
- that `BatchJobDetailSchema` returns a `BatchJob` instance with
`status_reason`
left as `None` when the API omits it,
- that `BatchDescribeJobsResponseSchema` builds one `BatchJob` per entry,
accepts
an empty `jobs` list, and propagates a nested job's `ValidationError`.
No production code is touched.
### What
13 tests added. The module's entry is removed from `OVERLOOKED_TESTS` in the
same
PR, as that list fails when a listed test file exists.
Verified locally:
```
uv run --project providers/amazon pytest \
providers/amazon/tests/unit/amazon/aws/executors/batch/test_boto_schema.py
-v
# 13 passed
uv run --project airflow-core pytest \
airflow-core/tests/unit/always/test_project_structure.py -q
# 10 passed, 1 xfailed
```
related: #35442
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Opus 5) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
