uranusjr commented on code in PR #69746: URL: https://github.com/apache/airflow/pull/69746#discussion_r3947053018
########## providers/standard/src/airflow/providers/standard/triggers/temporal.py: ########## @@ -22,11 +22,130 @@ from typing import Any import pendulum +from pendulum.tz.timezone import FixedTimezone, Timezone from airflow.providers.common.compat.sdk import timezone from airflow.triggers.base import BaseTrigger, TaskSuccessEvent, TriggerEvent +def _parse_timezone(value: str | int | datetime.tzinfo) -> Timezone | FixedTimezone: Review Comment: Logic in this function is partially available in `timezone.parse_timezone` (`timezone` is already imported above). Let’s just call it instead of reimplementing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
