yuseok89 opened a new pull request, #72638:
URL: https://github.com/apache/airflow/pull/72638
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
`GCSToSFTPOperator` copies every name `GCSHook.list()` returns, including
the trailing-`/` folder markers a GCS listing contains. Here a marker does not
just add a stray file. It fails the task.
`_resolve_destination_path` normalises the target with `os.path.normpath`,
which strips the trailing slash, so `folder/` targets the file path
`<dest>/folder`. GCS lists lexicographically, so the marker is written first.
`folder/file.txt` then needs `<dest>/folder` to be a directory, and
`SFTPHook.create_directory` raises `"... already exists and is a file"`.
The fix drops a trailing-`/` key only when it is also a strict prefix of
another key in the same listing, meaning a directory whose children are right
there. An object that merely happens to end in `/` has no such overlap and is
left alone.
## Before / After
Listing: `folder/` (a marker), `folder/file.txt`, and `lonely/` (a real
object whose name ends in `/`).
| Source object | Before | After |
|---|---|---|
| `folder/` | written as a file at `<dest>/folder` | skipped |
| `folder/file.txt` | **never transferred, task fails** |
`<dest>/folder/file.txt` |
| `lonely/` | written as a file at `<dest>/lonely` | unchanged by this PR |
Writing `folder/` as a file is what breaks `folder/file.txt`. The path its
parent needs is already taken, and the task dies there.
Verified end to end against a real GCS bucket and an SFTP server: the
failure reproduces on `main` and the same run succeeds with this change.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
- Opus 5
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
