[
https://issues.apache.org/jira/browse/AIRFLOW-6521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012163#comment-17012163
]
ASF GitHub Bot commented on AIRFLOW-6521:
-----------------------------------------
mtagle commented on pull request #7118: [AIRFLOW-6521]: add project param to
bigQuery hook .getSchema method
URL: https://github.com/apache/airflow/pull/7118
---
Issue link: WILL BE INSERTED BY
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
- [ ] Description above provides context of the change
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN =
JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with
`[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> BigQuery hook .getSchema method should work for other projects
> --------------------------------------------------------------
>
> Key: AIRFLOW-6521
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6521
> Project: Apache Airflow
> Issue Type: Improvement
> Components: gcp, hooks
> Affects Versions: master
> Reporter: Moira Tagle
> Assignee: Moira Tagle
> Priority: Minor
>
> big query hook's .getSchema method will always get schemas for the project
> configured in the connection. The method should be extended to allow for an
> optional project id to be passed in.
> This is already the case for some other methods in the bigquery hook, but not
> .getSchema.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
