jason810496 commented on code in PR #72676:
URL: https://github.com/apache/airflow/pull/72676#discussion_r3955240201


##########
java-sdk/sdk/src/main/kotlin/org/apache/airflow/sdk/Client.kt:
##########
@@ -95,6 +95,36 @@ class Client internal constructor(
    */
   fun getVariable(key: String): Any? = impl.getVariable(key).value
 
+  /**
+   * Stores an Airflow variable, replacing any existing value.
+   *
+   * The value is stored as-is. Serialize structured data (for example to
+   * JSON) before storing it. Omitting [description] clears any existing
+   * description. A value supplied by a secrets backend (such as an
+   * `AIRFLOW_VAR_*` environment variable) still takes precedence over the
+   * stored value when the variable is read back.

Review Comment:
   I think we don't need to mention these just in case the further change in 
the airflow-core will cause the outdated description. We could just mentioned 
the behavior is depends on the Airflow server side, or not mention at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to