jason810496 commented on code in PR #72322:
URL: https://github.com/apache/airflow/pull/72322#discussion_r3955735697
##########
providers/google/tests/unit/google/cloud/log/test_gcs_task_handler.py:
##########
@@ -209,8 +209,20 @@ def test_upload(
mock_write_method.assert_called_once()
if delete_local_copy and mock_write_method_result:
mock_rmtree.assert_called_once_with(tmp_path.as_posix())
+ # shutil.rmtree is mocked here, so it never actually
removes the file from
Review Comment:
Could you help add the unit test like
https://github.com/apache/airflow/pull/70860 to ensure the correctness?
Especially for the case of `for cycle in range(1, 4): ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
