stephen-bracken opened a new issue, #72706:
URL: https://github.com/apache/airflow/issues/72706

   ### Description
   
   Multi team deployments use the same uniqueness constraints as regular 
airflow deployments, including dag_id, pool_id, variable_id and conn_id needing 
to be unique across the database. 
   This is problematic because resources for other teams are hidden, so a team 
will not know beforehand that a resource already exists. This creates two 
issues: a usability issue and a security issue. The usability issue is that two 
teams cannot define resources with the same id. This is a problem for teams 
which don't use naming conventions. 
   
   For example, both teams might want to create a dag called `load_data`, 
however when team 2 comes to try and define the dag they will get a parse error 
saying that the dag must be unique. This also creates a race condition at parse 
time on which team will be able to define the dag.
   Another example would be two teams wanting to create a pool for spark tasks 
called `spark`. This is a common scenario which currently requires one team to 
change the name of their pool.
   
   The security issue is that a team could use this method to guess the IDs of 
dags existing in other teams. This is not as important as the usability issue 
in my opinion but it is still worth noting.
   
   ### Use case/motivation
   
   Update the queries and uniqueness constraints for team resources 
(dags/pools/variables/connections) so that they are unique within a team, and 
the database constraint is a pair of (id, team_name) so that two teams can 
define the same dags or other resources.
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to