ethanstoner commented on code in PR #72292:
URL: https://github.com/apache/airflow/pull/72292#discussion_r3958836511
##########
airflow-core/tests/unit/timetables/test_cron_mixin.py:
##########
@@ -39,3 +41,20 @@ def test_dom_and_dow_conflict():
assert "(or)" in desc
assert "Every minute, on day 1 of the month" in desc
assert "Every minute, only on Monday" in desc
+
+
[email protected](
+ ("expression", "equivalent"),
+ [
+ pytest.param("0 0 ? * MON", "0 0 * * MON",
id="question-mark-day-of-month"),
+ pytest.param("0 0 1 * ?", "0 0 1 * *", id="question-mark-day-of-week"),
+ pytest.param("0 0 ? * ?", "0 0 * * *", id="question-mark-both"),
+ ],
+)
+def test_question_mark_is_not_a_dom_dow_conflict(expression, equivalent):
+ # croniter expands "?" to "*", so it must describe the same as the "*" form
+ # instead of being reported as a day-of-month/day-of-week conflict.
Review Comment:
Removed.
Re-ran the file after taking it out: 6 passed with the fix, and the three
`?` cases fail against the merge base parent `caa8f286a0`, so the regression
test still bites. `test_dom_and_dow_conflict` passes either way, so `* * 1 * 1`
still reports the real conflict.
Agreed that `*/1` belongs in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
