ferruzzi commented on PR #70578: URL: https://github.com/apache/airflow/pull/70578#issuecomment-5592389262
Closing this asit appears this has already landed. To be clear, your change was right, we just mixed up the merge order. This was split out of #66269 at review request, but #66269 then merged on 29 August still carrying the same six lines in `task-sdk/src/airflow/sdk/__init__.pyi`, so the split never got reflected in the parent. I compared the two changesets line by line and they are identical. All six are on `main` today, each exactly once: - `from airflow.sdk.definitions.callback import AsyncCallback, SyncCallback` - `from airflow.sdk.definitions.deadline import DeadlineAlert, DeadlineReference` - `"AsyncCallback"`, `"SyncCallback"`, `"DeadlineAlert"` and `"DeadlineReference"` in `__all__` So the gap you reported is closed, including `SyncCallback` which you argued for on stub/runtime parity grounds, and the fix is credited to you via #66269 either way. Thanks for doing the split, and apologies that it ended up unused. If you (or anyone else) sees this and thinks it's a mistake, please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
