fat-catTW commented on code in PR #71767:
URL: https://github.com/apache/airflow/pull/71767#discussion_r3964510746
##########
airflow-core/src/airflow/serialization/definitions/deadline.py:
##########
@@ -373,10 +373,13 @@ def _fetch_from_db(column, *, session: Session, dag_id:
str, run_id: str) -> dat
"""
from airflow.models import DagRun
Review Comment:
Thanks for review!
You were right, the existing integration test mocked out `_fetch_from_db`,
so it did not directly exercise this change.
I added direct DB-backed coverage for the serialized `_fetch_from_db` helper:
- a DagRun exists but the selected `logical_date` column is NULL, returning
`None` without logging `Could not find DagRun`
- no DagRun exists, preserving the existing missing-DagRun warning
I also kept the higher-level DagRun deadline tests for the call-site warning
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
