Rohitkanithi opened a new pull request, #72819: URL: https://github.com/apache/airflow/pull/72819
### Why `providers/amazon/src/airflow/providers/amazon/aws/waiters/base_waiter.py` is listed on the `OVERLOOKED_TESTS` allowlist in `airflow-core/tests/unit/always/test_project_structure.py`, tracked by meta-issue #35442. `BaseBotoWaiter` is the foundation class used to instantiate both synchronous and asynchronous custom Boto3 waiters across Amazon provider hooks, but lacked a dedicated unit test suite. ### How Adds `providers/amazon/tests/unit/amazon/aws/waiters/test_base_waiter.py` covering: - Initialization with default parameters (`deferrable=False`) and custom `deferrable=True`. - Proper instantiation and attribute assignment of `WaiterModel` and Boto client. - Synchronous waiter creation path via `botocore.waiter.create_waiter_with_client`. - Asynchronous / deferrable waiter creation path via `aiobotocore.waiter.create_waiter_with_client`. - Real `botocore.waiter.Waiter` object generation with valid waiter models. - Exception handling when an unknown waiter name is requested (`ValueError`). ### What 6 unit tests added. The module's entry is removed from `OVERLOOKED_TESTS` in `airflow-core/tests/unit/always/test_project_structure.py`. Verified locally: ``` uv run --project providers/amazon pytest providers/amazon/tests/unit/amazon/aws/waiters/test_base_waiter.py -v # 6 passed, 1 warning in 1.06s uv run --project airflow-core pytest airflow-core/tests/unit/always/test_project_structure.py -k test_providers_modules_should_have_tests -v # 1 passed, 10 deselected in 5.22s ``` related: #35442 --- ##### Was generative AI tooling used to co-author this PR? - [ ] Yes (please specify the tool below) --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
