CaptainAni187 commented on PR #72703: URL: https://github.com/apache/airflow/pull/72703#issuecomment-5604826035
Closing — this was fixed on main by #72774 (commit 3e8f918) while this PR was open, so the conflict here is my change against an equivalent one that already landed. Their approach negates up front with a `prefix` rather than my `is_negative` flag; same behaviour, including `<1s` staying unsigned for sub-second magnitudes. Their test covers the same cases too — both input types, `days=-5`, and the sub-second pair. Thanks @rjgoyln for the review earlier; the readability points you raised were good ones and I'd applied both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
