soupam05 commented on PR #71349: URL: https://github.com/apache/airflow/pull/71349#issuecomment-5607353043
> > What happens if client initialization succeeds but a later poll fails due to an authentication/configuration error? Should that error cause the cached client to be invalidated so that the next poll can rebuild it, or is the expectation that the trigger will terminate/retry? It would be good to define this now that the client is no longer recreated on every poll. > > The cached client isn’t invalidated when a poll fails. Existing retries still handle transient errors, but authentication errors such as 401/403 cause the pod trigger to report an error, and cleanup closes the client. Whether the task retries afterward depends on its retry settings. I’d keep that behavior for this PR unless we identify a case where client reuse requires additional recovery. Did you have a particular authentication setup or failure scenario in mind? That would help determine whether rebuilding the client would actually resolve it. Thanks, that clarifies the 401/403 handling. One follow-up: for a long-running trigger, if a refreshable credential expires and the Kubernetes API returns a 401, can we guarantee that the credential-refresh path is attempted before the 401 is treated as terminal? Ideally, an expected credential refresh should be transparent to the task rather than causing the trigger to fail and relying on a task-level retry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
