Daniel Standish created AIRFLOW-6528:
----------------------------------------
Summary: disable W503 flake8 check (line break before binary
operator)
Key: AIRFLOW-6528
URL: https://issues.apache.org/jira/browse/AIRFLOW-6528
Project: Apache Airflow
Issue Type: Bug
Components: pre-commit
Affects Versions: 1.10.7
Reporter: Daniel Standish
Flake8's W503 rule says there should be no line break before binary operator.
This rule is incompatible with black formatter, and is also in my opinion bad
style.
Status quo example with W503 check enabled:
{code}
@property
def sqlalchemy_scheme(self):
"""
Database provided in init if exists; otherwise, ``schema`` from
``Connection`` object.
"""
return (
self._sqlalchemy_scheme or
self.connection_extra_lower.get('sqlalchemy_scheme') or
self.DEFAULT_SQLALCHEMY_SCHEME
)
{code}
as required by black (W503 disabled)
{code}
@property
def sqlalchemy_scheme(self):
"""
Database provided in init if exists; otherwise, ``schema`` from
``Connection`` object.
"""
return (
self._sqlalchemy_scheme
or self.connection_extra_lower.get('sqlalchemy_scheme')
or self.DEFAULT_SQLALCHEMY_SCHEME
)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
