keith991001 opened a new pull request, #72857:
URL: https://github.com/apache/airflow/pull/72857

   Adds the missing test module for 
`airflow.providers.celery.executors.default_celery` and removes its entry from 
`OVERLOOKED_TESTS` in `test_project_structure.py`, per the checklist in the 
meta issue.
   
   Scope note: `test_celery_executor.py` already covers the module-reload paths 
for dict options / engine options / `task_acks_late` / the 
non-recommended-backend warning, so this module focuses on the uncovered 
surface with direct calls to the builders:
   
   - `_broker_supports_visibility_timeout` across the broker URL matrix.
   - `_broker_transport_options`: the implicit 24h `visibility_timeout` default 
(added for redis/sqs/sentinel, absent for amqp, user value respected) and the 
dict-option error paths (invalid JSON, non-dict JSON).
   - `get_default_celery_config`: defaults, explicit `result_backend` 
precedence, the `sql_alchemy_conn` fallback (including the 
driverless-PostgreSQL scheme rewrite and the non-Postgres passthrough), 
`extra_celery_config` merge/override, result-backend `sentinel_kwargs` parsing 
and its error path, and the no-`getsection` fallback to the global conf.
   - The SSL branch matrix: inactive default, redis vs amqp key naming, one-way 
TLS omitting client certs, mutual-TLS-without-certs and unsupported-broker 
errors.
   
   27 tests, all passing locally via `uv run --project providers/celery pytest 
...`; the `test_providers_modules_should_have_tests` guard passes with the 
entry removed.
   
   related: #35442
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Fable 5)
   
   Generated-by: Claude Code (Fable 5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to