RehanAhmad25 commented on code in PR #72499:
URL: https://github.com/apache/airflow/pull/72499#discussion_r3975377399
##########
task-sdk/src/airflow/sdk/definitions/param.py:
##########
@@ -382,6 +383,27 @@ def process_params(
if task.params:
params.update(task.params)
if conf.getboolean("core", "dag_run_conf_overrides_params") and
dagrun_conf:
Review Comment:
Confirmed, thanks. `dag_run.conf` stays reachable from task code and
templates via `context["dag_run"].conf` regardless of
`dag_run_conf_overrides_params`, but the masking call was nested inside the
same `if` block that gates whether `dagrun_conf` gets merged into task params,
so it was skipped entirely when that setting is `False`.
Pulled the `dagrun_conf` masking out into its own unconditional check above
this block, so it registers regardless of the override setting. Added
`test_masks_dagrun_conf_even_when_overrides_params_disabled` (using `conf_vars`
to set it to `False`), confirming the password value in `dagrun_conf` still
gets masked even though it never gets merged into the resolved params in that
case. Pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
