uranusjr commented on code in PR #69523:
URL: https://github.com/apache/airflow/pull/69523#discussion_r3975462803
##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -2423,7 +2463,17 @@ def process_log_messages_from_subprocess(
if level := NAME_TO_LEVEL.get(event.pop("level")):
msg = event.pop("event", None)
for target in loggers:
- target.log(level, msg, **event)
+ _log_to_target(target, level, msg, **event)
+
+
+def _log_to_target(target: FilteringBoundLogger, level: int, msg: str | None,
**event) -> None:
+ rendered_msg = msg if msg is not None else ""
Review Comment:
Instead od doing this here, probably better to do `msg = event.pop("event",
"")` a few lines above instead, and have `msg: str` instead. The only other
place this function is called (in `forward_to_log`) always passes a str.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
