uranusjr commented on code in PR #65618:
URL: https://github.com/apache/airflow/pull/65618#discussion_r3975795991
##########
providers/common/sql/src/airflow/providers/common/sql/operators/sql.py:
##########
@@ -554,29 +624,78 @@ def _should_run_output_processing(self) -> bool:
def execute(self, context):
Review Comment:
With the defaults (`deferrable=True, enforce_read_only=True`) on a
non-Postgres DbApiHook, the operator goes through here, defers, and only fails
in the triggerer with NotImplementedError from `aget_hook`.
Worth validating async/read-only hook support in `execute()` before
deferring, so users get an immediate failure on the worker instead of a
deferred one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
