jeff3071 commented on code in PR #72002:
URL: https://github.com/apache/airflow/pull/72002#discussion_r3978887874
##########
providers/common/ai/docs/operators/llamaindex_embedding.rst:
##########
@@ -94,6 +94,10 @@ Parameters
* - ``embed_conn_id``
- Optional separate connection ID for the embedding provider. Falls
back to ``llm_conn_id`` when ``None``.
+ * - ``embedding_kwargs``
+ - Additional keyword arguments passed to the embedding model constructor
+ when ``embed_model`` is a string or omitted, for example
+ ``{"dimensions": 128}``. Templated.
Review Comment:
Thanks for the detailed review!
I updated both operator parameter tables to mark all fields listed in
template_fields consistently. For `embedding_kwargs`, the docs now clarify that
templated typed values such as dimensions require
`render_template_as_native_obj=True` to remain integers rather than strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
