Kunal8954 commented on PR #72879: URL: https://github.com/apache/airflow/pull/72879#issuecomment-5618468197
Thanks for working on this feature. I reviewed the implementation and found a few areas that may be worth addressing before merge: sync name lookup should avoid the private _fetch_all_jobs() method, async lookup should handle pagination when selecting the newest job, and the trigger should avoid mutating its serialized job_id state. I also found a few useful regression cases around job_id/job_name exclusivity, newest-match selection, no-match behavior, and trigger serialization. I have a tested version of these changes locally with the relevant Dataflow tests passing. Happy to share the patch/commit if useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
