FrankYang0529 commented on code in PR #72858:
URL: https://github.com/apache/airflow/pull/72858#discussion_r3979568446
##########
airflow-core/src/airflow/cli/cli_parser.py:
##########
@@ -76,6 +104,11 @@
log.warning("Failed to load CLI commands from providers: %s", e)
# do not re-raise for the same reason as above
+ # Commands registered through a provider "cli" section take precedence
over the compat loading below
+ provider_command_names = {command.name for command in airflow_commands} - {
Review Comment:
Thanks for the review. With a celery provider that has no `cli` section, and
`CeleryExecutor` plus a subclass configured together, it raises
`CliConflictError` on `celery`. I applied your suggestion:
`_exclude_registered_commands` now adds each kept name to the set. I renamed
the set to `registered_command_names`, since it no longer holds only provider
commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
