pierrejeambrun commented on code in PR #72435:
URL: https://github.com/apache/airflow/pull/72435#discussion_r3980331501


##########
airflow-core/newsfragments/72435.feature.rst:
##########
@@ -0,0 +1 @@
+Add a toggle to hide Task Group durations on the Gantt chart.

Review Comment:
   To remove



##########
airflow-core/src/airflow/ui/src/layouts/Details/DetailsLayout.tsx:
##########
@@ -112,7 +112,6 @@ export const DetailsLayout = ({ children, error, isLoading, 
outletContext, tabs
     `version_indicator_display_mode`,
     VersionIndicatorOptions.ALL,
   );
-

Review Comment:
   ?
   
   Unrelated remove please.



##########
airflow-core/src/airflow/ui/src/layouts/Details/Gantt/GanttTimeline.tsx:
##########
@@ -387,6 +399,26 @@ export const GanttTimeline = ({
                                 <StateIcon size={GANTT_STATE_ICON_SIZE_PX} 
state={state} />
                               )}
                             </Badge>
+                            {node.isGroup === true ? (
+                              <Box

Review Comment:
   Why an extra box?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to