kaxil commented on a change in pull request #7038: [AIRFLOW-4495] allow
externally triggered dags to run for future exec dates
URL: https://github.com/apache/airflow/pull/7038#discussion_r365221908
##########
File path: tests/ti_deps/deps/test_runnable_exec_date_dep.py
##########
@@ -37,14 +37,14 @@ def _get_task_instance(self, execution_date,
dag_end_date=None, task_end_date=No
@freeze_time('2016-01-01')
def test_exec_date_after_end_date(self):
"""
- If the dag's execution date is in the future this dep should fail
+ If the dag's execution date is in the future this dep should succeed
"""
ti = self._get_task_instance(
dag_end_date=datetime(2016, 1, 3),
task_end_date=datetime(2016, 1, 3),
execution_date=datetime(2016, 1, 2),
)
- self.assertFalse(RunnableExecDateDep().is_met(ti=ti))
+ self.assertTrue(RunnableExecDateDep().is_met(ti=ti))
Review comment:
Can you also add a test to check the new feature to test the behavior when
config is enabled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
