Har1sh-k commented on issue #72902:
URL: https://github.com/apache/airflow/issues/72902#issuecomment-5636724305

   Tested `apache.hive 9.6.2rc1` for #66751, installed from PyPI into a clean 
venv on Airflow 3.3.1 (with mysql 6.6.2 and presto 5.12.1). Works for me.
   
   What I exercised, driving `HiveStatsCollectionOperator.execute` with the 
metastore, Presto and MySQL hooks stubbed and capturing the SQL and parameters:
   
   - The Presto stats query renders the WHERE clause with the hook's own 
placeholder and passes the partition values through `get_first(sql, 
parameters=...)`, so the values are no longer interpolated into the statement.
   - The `hive_stats` SELECT and the DELETE on the previous-run path both use 
`%s` with `parameters=`, binding table name, partition repr and dttm.
   - Identifier quoting behaves as intended: a hyphenated column and partition 
key come out as `"weird-col"` and `"dt-col"`, `db.odd-table` becomes 
`db."odd-table"` with the catalog left plain, `db."already.quoted"` is passed 
through without being re-escaped, and plain word identifiers are still emitted 
unquoted. That is the case that used to produce an invalid statement.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to