rjgoyln opened a new pull request, #73035: URL: https://github.com/apache/airflow/pull/73035
## Summary `get_secret` passed the secret id as a second positional argument to `NotFound`. That argument is `errors`, not a format argument — `google.api_core` renders only the status code and `message`, and silently drops `errors` entries that do not expose `.code` and `.message`. So the placeholder was never filled and the id never surfaced anywhere: ``` 404 The secret '%s' not found ``` Which secret is missing is the only detail that makes the error actionable. ## Change - Interpolate `secret_id` into the message. - Point `example_ads.py` at the shared helper rather than its own copy, which carried the same bug. - Tighten the existing not-found test with `match=`, which the old message fails. --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes — Claude Code (Opus 5) Generated-by: Claude Code (Opus 5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
