shahar1 opened a new pull request, #73036:
URL: https://github.com/apache/airflow/pull/73036

   related: #70296
   
   ## Human Summary
   This completes the template field handling within the PsrpOperator so we'll 
be able to remove it from the burn-down list.
   The problem here is that that when `cmldet` is rendered, then the default 
read will become the un-rendered Jinja value within `task_id`.
   I'm concerned that slow deprecation in this case will be less visible than 
break (it will appear in the logs, but not in the UI) - so I'd rather go with 
hard removal and a breaking change to get done with it.
   I've added a changelog note that explains what should be changed (adjustment 
should be simple).
   
   ## AI Summary
   <details><summary>Click here</summary>
   `PsrpOperator` no longer derives `task_id` from `cmdlet`; `task_id` is now 
required, as on every other operator.
   
   `cmdlet` is a template field, rendered after the constructor runs, so the 
default read the un-rendered Jinja value. It was the last construction-time 
read keeping `PsrpOperator` in `validate_operators_init_exemptions.txt`, and it 
cannot move to `execute()` because `task_id` must exist before 
`BaseOperator.__init__`. #70347 deliberately kept the default because dropping 
it changes task identity for Dags that relied on it, and deferred the removal 
to a separate change; this is that follow-up.
   
   This is a breaking change for Dags that omitted `task_id` when using 
`cmdlet`. Those Dags now fail at import with a missing `task_id` error, and 
keep their existing task identity by passing `task_id` explicitly with the 
cmdlet name. A note is added under the changelog header so the release manager 
cuts a major version.
   </details>
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Fable 5.1)
   
   Generated-by: Claude Code (Fable 5.1) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to