fat-catTW opened a new pull request, #73037:
URL: https://github.com/apache/airflow/pull/73037
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
## Why
Several task execution comms result classes repeated the same API response
conversion logic, making each wrapper manually copy response fields and set the
result discriminator.
Changing `comms.py` also runs the supervisor schema version hook, which
needs to compare against a temporary `upstream/main` worktree. That hook could
fail from `git commit` when it inherited Git-local hook environment variables.
## Solution
Add shared mixins for the common conversion shapes:
- `_APIResponseResultMixin` handles API response wrappers that only need
`model_dump(exclude_defaults=True)`.
- `_TypedAPIResponseResultMixin` also restores the `type` discriminator
required by task comms serialization.
Update the matching result wrappers to use `from_api_response()`. Keep
custom converters where the shape is different, such as `ConnectionResult`
needing `by_alias=True`, `AssetsByAliasResult` mapping a list of assets, and
XCom sequence wrappers extracting `root`.
Also clear Git-local hook environment variables when the supervisor schema
version check creates the temporary upstream worktree, so the hook works
correctly from `git commit`.
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- `[X]` Yes (please specify the tool below)
Generated-by: [Codex] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
