xBis7 commented on code in PR #72458:
URL: https://github.com/apache/airflow/pull/72458#discussion_r3999363709
##########
shared/observability/src/airflow_shared/observability/common.py:
##########
@@ -30,6 +31,20 @@
log = structlog.getLogger(__name__)
+def expand_dag_tags(tag_names: Iterable[str]) -> dict[str, str]:
+ """Expand DAG tag attributes into key-value pairs."""
+ result: dict[str, str] = {}
+ for name in tag_names:
+ key, _, value = name.partition(":")
+ result[key] = value
+ return result
+
+
+def build_dag_tags(tag_names: Iterable[str]) -> dict[str, str]:
Review Comment:
I'm all in favor of keeping the scope of a PR properly defined so that it's
easy to review and for many other reasons. But in this community, it's hard to
get reviews and feedback from commiters/maintainers due to the popularity of
the project and the huge backlog of PRs.
I've approved the PR, and based on your comments the current state looks
good to me. If the planned changes aren't that extensive, It might be a good
idea to include them in this patch and not a follow-up.
Both PRs might get merged in 10 days or it could be in 3 months or 6 months.
You just don't know. There is too much work load.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
