rjgoyln commented on PR #71195: URL: https://github.com/apache/airflow/pull/71195#issuecomment-5652972680
Superseded by #70991, which fixed the same bug from the other side: `Credentials.save()` now raises `AirflowCtlCredentialNotFoundException` before it ever reaches `keyring.set_password`, and the `except TypeError` handler this PR was widening has been removed entirely. #70991 also carries the equivalent coverage — `test_save_propagates_unexpected_keyring_error` and `test_save_without_token`, the latter additionally asserting that `set_password` is not called. Checked against current `main`: both tests added here pass with this PR's production change reverted, so there is nothing left for them to distinguish. Closing. --- Drafted-by: Claude Opus 5 (1M context) (no human review before posting) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
