potiuk opened a new pull request, #73108:
URL: https://github.com/apache/airflow/pull/73108

   Backport of the `java-sdk/.gitattributes` half of #69444 to `v3-3-test`.
   
   ASF policy does not permit compiled binaries in a source release, and the
   Gradle wrapper is not one of the exempted build tools
   ([LEGAL-570](https://issues.apache.org/jira/browse/LEGAL-570)). `main` 
stopped
   shipping `java-sdk/gradle/wrapper/gradle-wrapper.jar` in #69444.
   
   Only half of that change reached this branch. The breeze side is already 
here —
   `kubernetes_commands.py` restores `gradlew` / `gradlew.bat` after `git 
archive`
   drops them — but the `.gitattributes` side never followed, so nothing is
   actually dropped and the 43 KB jar is still in the **3.3.2rc1** source 
tarball.
   
   Verified with `git archive` against `v3-3-test`:
   
   | | before | after |
   |---|---|---|
   | `.jar` files in source tarball | 1 | **0** |
   | `gradle-wrapper.properties` | kept | kept |
   | `gradlew` / `gradlew.bat` | shipped | stripped (breeze restores them) |
   | `java-sdk/.editorconfig` | **not shipped** | shipped |
   
   `gradle-wrapper.properties` stays on purpose — it carries the pinned Gradle
   version and distribution checksum a verifier needs to regenerate the wrapper.
   
   Carrying the rest of the file over also fixes a second, latent problem on 
this
   branch: the root `.gitattributes` strips `.editorconfig`, but ktlint reads 
it at
   build time and the build task requires that lint to pass, so the source 
release
   was missing a file its own build needs.
   
   ### Not a blocker for 3.3.2
   
   Found while verifying 3.3.2rc1. **Non-blocking** — the same jar is in the
   already-released 3.3.1, so it is long-standing rather than a regression. If 
an
   rc2 happens for other reasons this should ride along; it does not justify 
one on
   its own.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Opus 5
   
   Generated-by: Claude Opus 5 following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to