Vamsi-klu commented on code in PR #73097:
URL: https://github.com/apache/airflow/pull/73097#discussion_r4002488064
##########
airflow-ctl/src/airflowctl/ctl/cli_config.py:
##########
@@ -959,9 +959,15 @@ def _create_group_commands_from_operation(self):
)
)
- @property
+ @cached_property
Review Comment:
The cache is load-bearing because the builders still append. del
factory.group_commands (the documented way to refresh a cached_property) runs
them again on already-filled operations / commands_map / group_commands_list
and recreates the doubled tree this PR exists to stop.
Zero those three collections at the start of group_commands, then cache or
not. After that, invalidation stays safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
