namanjain24-sudo commented on PR #73104: URL: https://github.com/apache/airflow/pull/73104#issuecomment-5661331099
Thanks for the careful review, both points are addressed now. - Added a note to `providers/fab/docs/changelog.rst`. One small correction on the scope: for a custom role, the per-request `sync_roles()` only ever added `can_read` on `Website`. I checked both sides. Before this change a role created with `actions=[]` had it after the next request. Now it gets it at startup or after `airflow sync-perm`. The note says exactly that. - Added `test_requests_reuse_the_auth_manager_flask_app` for roles and users. It uses the real FabAuthManager app and DB, with only the user and the authorization check faked. It sends two requests and asserts that `AirflowAppBuilder.init_app` is never called and that `flask_app`/`appbuilder` stay the same. Against the old routes it fails with `Expected 'init_app' to not have been called. Called 2 times.` I also rebased on latest main and reran everything there. The api_fastapi tests pass on sqlite and Postgres 16, the full fab unit suite passes, prek and mypy are clean, and the `Website` behaviour above holds on both the old and new routes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
