zozo123 commented on code in PR #71676: URL: https://github.com/apache/airflow/pull/71676#discussion_r4003838881
########## providers/common/ai/docs/toolsets.rst: ########## @@ -793,6 +793,56 @@ Constructor parameters: guarantee this backend cannot make. Set ``"deny-all"`` after running ``sbx policy init deny-all``, or ``"allow-all"`` to state that egress is open. +OpenSandbox backend Review Comment: Done — recording is in the PR thread: a full end-to-end run against a real OpenSandbox server (`opensandbox/server:v0.2.3`, SDK `0.1.16`, Docker runtime, arm64). It covers API-key enforcement, all four `SandboxToolset` tools driven by a real pydantic-ai agent, this PR's own system-test Dag task, the `SandboxSpec` fail-closed egress matrix, and teardown. Running it surfaced two genuine defects, both now fixed with test coverage: the system test could never construct (30s ceiling vs the 60s default), and command output was losing every line break. Details in the PR comment. --- Drafted-by: Claude Code (Opus 5); reviewed by @zozo123 before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
