ephraimbuddy commented on code in PR #72721:
URL: https://github.com/apache/airflow/pull/72721#discussion_r4006491873
##########
airflow-core/tests/unit/models/test_dagrun.py:
##########
@@ -4172,18 +4222,67 @@ def on_failure(context):
dr.dag_model = DagModel.get_dagmodel(dag.dag_id, session=session)
ti = dr.get_task_instance("test_task")
ti.dag_version_id = None
+ dr.created_dag_version_id = None
session.flush()
dag.on_failure_callback = on_failure
dag.has_on_failure_callback = True
- dr.produce_dag_callback(dag=dag, success=False, relevant_ti=ti,
reason="task_failure", execute=True)
+ dr.produce_dag_callback(
+ dag=dag,
+ success=False,
+ relevant_ti=ti,
+ reason="task_failure",
+ execute=True,
+ session=session,
+ )
- # Callback still fires with the minimal fallback context (no last_ti
template vars).
assert context_received is not None
assert context_received["reason"] == "task_failure"
- assert "ti" not in context_received
- assert context_received["run_id"] == dr.run_id
+ assert context_received["ti"].task_id == "test_task"
+ assert context_received["ti"].run_id == dr.run_id
+ assert (
+ context_received["ti"].dag_version_id
+ == DagVersion.get_latest_version(dag.dag_id, session=session).id
Review Comment:
Changed the test to capture `dr.created_dag_version_id` before clearing it
and assert against that value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
