dilnazanlid commented on PR #72442:
URL: https://github.com/apache/airflow/pull/72442#issuecomment-5665929733
Closing this in favour of a single change where we replace the
`dag_processing/importers` to `sdk/importers`.
This PR introduces the `[dag_processor] dag_importer_configs` option and the
per-bundle `importers` key, and wires them into
`airflow.dag_processing.importers`.
That package is transitional: AIP-85 replaces it with
`airflow.sdk.importers`,
which already implements this exact config parsing in
`DagImporterRegistry.from_config()` and `_get_bundle_importers_config()`.
So landing the config here means (a) building plumbing in a package that the
very
next PR deletes, and (b) shipping an interim state where one option is read
by two
different registries. Neither is worth the review cycles.
The follow-up PR will instead do it in one step:
- declare `[dag_processor] dag_importer_configs` and the per-bundle
`importers`
key in `config.yml`,
- wire `airflow.sdk.importers` into the Dag processor,
- remove `airflow.dag_processing.importers`.
All the discussed points here were already accommodated in the sdk/importers
in https://github.com/apache/airflow/pull/72369. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
