vincbeck commented on PR #72542: URL: https://github.com/apache/airflow/pull/72542#issuecomment-5670594212
> I'm not sure I'm in favour of bumping the minimum cncf version to bleeding edge. If users don't install with the amazon extra (`apache-airflow-providers-amazon[cncf.kubernetes]`) and instead are installing with (`apache-airflow-providers-amazon`, which won't bump their cncf version) or if they for some reason cannot upgrade cncf to the bleeding edge then all the operators in eks.py will fail to load due to the import failure of the cncf Excec operator. > > You can actually see another different, but similar, workaround we put in to avoid bumping this floor previously: > > https://github.com/apache/airflow/blob/503e8072065e1aa15f773e1499e15eedb254e031/providers/amazon/src/airflow/providers/amazon/aws/operators/eks.py#L55-L61 > > I think @SameerMesiah97 instincts were right here, we should at least for a few releases have some error handling if that import fails. > > @vincbeck @ferruzzi thoughts? > > Putting a request for changes for now to avoid merging this until we're decided. I agree with Niko hee -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
