amoghrajesh commented on code in PR #70298:
URL: https://github.com/apache/airflow/pull/70298#discussion_r4012619561
##########
dev/registry/extract_parameters.py:
##########
@@ -391,28 +392,138 @@ def load_resumable_job_mixin() -> type | None:
return None
+# Matches an actual self.defer() call or self.deferrable attribute read, but
not
+# self.defer_for_approval(). TaskDeferred catches operators that raise it
directly instead of
Review Comment:
Confirmed the wider scope: nine operators across `common.ai` and standard
share the same shape, a real `self.defer(...)` gated by a version check that is
True on this core. Fixed it so the code actually understands that this line
only runs on an older Airflow version, and excludes it when deciding if
something is deferrable. Also fixed a case where a decorator was hiding the
real module the check needed to look at. Updated the `DefersForApprovalOnly`
fixture to carry the real shape instead of a stub, and added a fixture for the
direct-in-execute case plus one confirming the reachable case still works.
##########
registry/src/css/main.css:
##########
@@ -3297,6 +3298,26 @@ main {
max-width: 16rem;
}
+.capability-filter-toggles {
Review Comment:
Fixed, added `flex-wrap` so the checkboxes wrap onto a new line instead of
overflowing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
