namanjain24-sudo commented on issue #73152:
URL: https://github.com/apache/airflow/issues/73152#issuecomment-5684361799

   Thanks @DianaHov. Before starting a PR I checked `main`, and this exact 
change has already landed: #71488 passes `session=session` to `ti.set_state` in 
`_set_dag_run_terminal_state`. It was merged as a performance fix, so it never 
got linked to this issue. It was backported in #71955 and is included in 
3.3.2rc1, which is on PyPI.
   
   I verified it against the `3.3.2rc1` tag on Postgres 16 with an API test on 
an un-started run: marking it success or failed now returns 200 on the first 
attempt. With that one line reverted to its 3.3.1 form, the same test returns 
the 409 on the `dag_run_note` insert whenever `note` is null (what the UI sends 
if the Note box is left untouched) or has text.
   
   So there's nothing left to fix in a separate PR. If you get a chance to try 
3.3.2rc1 in your setup, a comment on #73089 (the RC testing issue) would help 
the release along, and this issue can then be closed as fixed by #71955.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to