SameerMesiah97 commented on code in PR #71653:
URL: https://github.com/apache/airflow/pull/71653#discussion_r4019294939
##########
providers/amazon/src/airflow/providers/amazon/aws/triggers/sagemaker.py:
##########
@@ -108,6 +109,41 @@ def hook(self) -> AwsGenericHook:
config=self.botocore_config,
)
+ def _event_from_exception(self, error: AirflowException) -> TriggerEvent:
+
+ if isinstance(error, WaiterMaxAttemptsError):
Review Comment:
Yes. `async_wait` catches `NoCredentialsError` on each attempt and
increments the attempt counter, so if every attempt fails due to missing
credentials it will eventually raise `WaiterMaxAttemptsError`. I understand
that missing credentials will be transmuted into a generic timeout event but it
might be okay here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
