guan404ming commented on PR #72159: URL: https://github.com/apache/airflow/pull/72159#issuecomment-5693990007
Thanks for the thorough pass. All five addressed in a514f2d260: - `llm.py:32`: `BaseNotifier` now imported from `compat.notifier`, `approval.py` `TYPE_CHECKING` import too. - `approval.py:180`: docs, docstring and param doc state retries re-notify with regenerated output. - `approval.py:184`: `TemplateError` propagates and fails the task; delivery errors still log. Context copy restored. - `llm.rst:213`: example DAG gains `LogNotifier`; `llm_sql.rst` colon fixed; decorator and sensitivity notes added. - `llm.py:148`: scalars and `str` rejected before iteration, hint is `Iterable`, tests cover each case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
