Lee-W commented on code in PR #73113:
URL: https://github.com/apache/airflow/pull/73113#discussion_r4024522366
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-CN/components.json:
##########
@@ -93,11 +105,15 @@
"downloadImageError": "下载图表图片失败。",
"downloadImageErrorTitle": "下载失败",
"otherDagRuns": "+ 其他 Dag 执行",
- "taskCount_one": "1 个任务",
+ "taskCount_one": "{{count}} 个任务",
"taskCount_other": "{{count}} 个任务",
"taskGroup": "任务分组",
"zoomToTask": "缩放至选定任务"
},
+ "jsonPreview": {
+ "items_one": "{{count}} 项",
Review Comment:
does make it
```suggestion
"items_one": "1 项",
```
make sense?
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-CN/components.json:
##########
@@ -93,11 +105,15 @@
"downloadImageError": "下载图表图片失败。",
"downloadImageErrorTitle": "下载失败",
"otherDagRuns": "+ 其他 Dag 执行",
- "taskCount_one": "1 个任务",
+ "taskCount_one": "{{count}} 个任务",
Review Comment:
do we really need this change?
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-CN/components.json:
##########
@@ -111,7 +127,15 @@
"file": "文件",
"location": "第 {{line}} 行，位于 {{name}}"
},
+ "passwordToggle": {
+ "hide": "隐藏值",
+ "show": "显示值"
Review Comment:
we didn't include "值". but this is only an FYI instead of a suggestion
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-CN/dags.json:
##########
@@ -73,9 +84,33 @@
"preventRunningTasks": "防止重复执行执行中的任务",
"queueNew": "加入新任务到队列",
"runOnLatestVersion": "执行最新套件包版本",
+ "runOnLatestVersionForced": "始终使用最新版本，因为没有可回退的早期版本",
"upstream": "上游"
}
},
+ "runStateCounts": {
+ "label": "执行状态",
+ "loading": "正在加载执行状态计数",
+ "tooltip": "{{state}}：{{formattedCount}}，点击以筛选执行"
+ },
+ "schedulingActions": {
Review Comment:
We use "恢復排程" instead. I kinda feel it's wrong for zh-CN, but still and FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
