radhwene commented on code in PR #68361:
URL: https://github.com/apache/airflow/pull/68361#discussion_r4024832146
##########
generated/known_airflow_exceptions.txt:
##########
@@ -213,7 +213,7 @@
providers/google/src/airflow/providers/google/cloud/hooks/cloud_build.py::3
providers/google/src/airflow/providers/google/cloud/hooks/cloud_composer.py::5
providers/google/src/airflow/providers/google/cloud/hooks/cloud_memorystore.py::5
providers/google/src/airflow/providers/google/cloud/hooks/cloud_run.py::1
-providers/google/src/airflow/providers/google/cloud/hooks/cloud_sql.py::32
+providers/google/src/airflow/providers/google/cloud/hooks/cloud_sql.py::33
Review Comment:
Hi @shahar1 ,
done in d21e9e4e69. The two import failure paths (`_submit_import` and the
polling step in `import_instance`) now raise a new
`CloudSQLImportError(AirflowException)`, defined in `hooks/cloud_sql.py`. I
defined it in the hook module rather than reusing `CloudSQLOperationError`
from `sensors/cloud_sql.py`, because the sensor module imports the hook and
reusing it would create an import cycle.
The allowlist entry goes from `::32` on main to `::31`, so this PR now
removes one `AirflowException` instead of adding one. Tests assert on
`CloudSQLImportError`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
