SameerMesiah97 commented on code in PR #73246:
URL: https://github.com/apache/airflow/pull/73246#discussion_r4027521586
##########
providers/google/src/airflow/providers/google/cloud/transfers/local_to_gcs.py:
##########
@@ -165,6 +168,8 @@ def get_openlineage_facets_on_start(self):
dest_object = self.dst if os.path.basename(self.dst) else
extract_ds_name_from_gcs_path(self.dst)
Review Comment:
Should the destination object also be checked before constructing the output
dataset? If the templated `dst` resolves to `None` or an empty string, it looks
like this could still emit a dataset with no name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
