shahar1 commented on PR #72697:
URL: https://github.com/apache/airflow/pull/72697#issuecomment-5702815937
> > Are you talking about a pre-commit that enforces EM102 witha burn-down
list, or something else? If it's the former - I won't resist.
>
> Not EM102 — that’s the gap I ran into. EM101/102/103 only check the first
argument, so `raise AirflowException("... %s", value)` still passes. There’s
also no Ruff equivalent of pylint’s W0715.
>
> I’m thinking of a separate hook in the `check-no-new-airflow-exceptions`
mould: flag `raise <Exception>(<str literal>, <more args>)`, with a burn-down
allowlist for existing cases.
>
> Of the 45 sites, most are cosmetic; only `google.api_core` subclasses
actually lose the extra args, and the remaining case is already covered by
#73035. So this would mainly be for consistency and preventing new cases.
Sounds good to me🙂 Feel free to raise a PR for that (even better if you
could raise it in Ruff)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
