kaxil commented on PR #71437:
URL: https://github.com/apache/airflow/pull/71437#issuecomment-5707251447
Two blocking items in the review above, both small, and everything from the
earlier rounds is now closed.
The first is the `TypeError` re-raise in `create_provider`: it names the
kwargs that were supplied but not the one the provider rejected, and since
`test_connection` returns `str(e)` the cause never reaches the Test button.
Appending `: {e}` covers it, and also stops a `TypeError` raised inside a
provider's own body being relabelled as a connection-field problem.
The second is the new ignored-fields warning. It looks only at
`conn.password` and `conn.host`, which `pydanticai_vertex` hides, so a Vertex
connection with Project and Location set plus a `google:` model drops both
fields and reaches ADC with nothing in the log. A second tuple on
`_ProviderConnectionConfig` for the extra keys a mapper is known to drop fits
the structure that is already there.
Fix those two and I'll approve. The rest of the comments are optional and
none of them need another review round: I can confirm the two fixes from the
diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
