sgoel2be24-cyber commented on PR #70472:
URL: https://github.com/apache/airflow/pull/70472#issuecomment-5709046710
I tested this PR against current `main` (`386132ef`, 2026-09-16). The diff
still applies cleanly, with no rebase conflicts.
**Tests (run locally, Python 3.10 uv env from `airflow-ctl/`):**
- `TestTasksOperations::test_list[no-order-by|with-order-by]` and
`TestCliConfigMethods::test_tasks_list_args` pass. They fail without the
`operations.py` change (`AttributeError: 'TasksOperations' object has no
attribute 'list'` / `StopIteration`), so they cover the change.
- Full `airflow-ctl` unit suite: `397 passed`.
- `prek run --files <changed files>`: ruff, ruff-format, mypy for
airflow-ctl, `check-airflowctl-command-coverage`, `check-airflowctl-help-texts`
and the other hooks pass. I couldn't run `generate-airflowctl-help-images`
locally because it needs breeze, so CI needs to confirm the `tasks` hash and
SVG.
**About the red `Airflow CTL tests / airflow-ctl:P3.10 tests` job:** it
failed only in
`tests/airflow_ctl/ctl/commands/test_task_command.py::TestFailedDeps`
(`ValidationError: 19 validation errors for TaskInstanceResponse`). This PR
doesn't touch that file, and all of `TestFailedDeps` passes on current `main`
with this diff applied. It looks like a breakage that was on `main` when the
job ran (2026-07-30), so a rebase or CI re-run should turn it green.
**Code:** the implementation looks right to me.
- `GET /dags/{dag_id}/tasks` isn't paginated (it returns every task plus
`total_entries`), so calling `client.get` directly instead of `execute_list`
fits.
- `_build_query_params` leaves `order_by` out when it's unset, so the
server's default (`task_id`) applies.
One small suggestion: #66173 lists `TasksOperations.list` as the only
operation from its original checklist that isn't on `main` yet. `get`,
`get_dependencies` and `list` on `TaskInstancesOperations`, and
`TasksOperations.clear`, have all been merged. Adding `related: #66173` to the
description would link that issue to this PR.
---
Drafted-by: Claude Code (Opus 5); reviewed by @sgoel2be24-cyber before
posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
