ashb commented on code in PR #73249:
URL: https://github.com/apache/airflow/pull/73249#discussion_r4034158843
##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -1734,10 +1719,10 @@ def final_state(self):
Not valid before the process has finished.
"""
+ if self._terminal_state == SERVER_TERMINATED:
Review Comment:
Hmmmm yes. I was already not too happy about "final_state doesn't already
mean final state". The fact that you brought it up too: I'm going to see if I
can change it so it's structurally impossible to misuse this field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
