Lee-W commented on code in PR #72786:
URL: https://github.com/apache/airflow/pull/72786#discussion_r4034919489
##########
providers/common/ai/docs/toolsets.rst:
##########
@@ -1358,6 +1394,24 @@ Groups nest.
members=[bedrock_claims_agent, foundry_claims_agent], # same image,
two clouds
)
+.. note::
+
+ Each member still needs its own ``tool_name`` -- the constructor rejects
+ an empty one -- but nothing reads it once the member is inside a group.
+ The group calls only ``member.invoke()``, never ``member.get_tools()``,
+ so a member's ``tool_name``, ``description``, and ``max_retries`` are
+ inert; only the group's own values reach the calling model.
+
+.. note::
+
+ The same is true in reverse for ``timeout``:
``FailoverManagedAgentToolset``
+ does not override the ``timeout`` property, so it just mirrors whatever
+ the group's own constructor received, and the group's ``invoke()`` above
+ calls only ``member.invoke(prompt)`` -- it never reads ``self.timeout``.
+ Passing ``timeout=`` to a failover group is therefore a silent no-op; set
Review Comment:
`FailoverManagedAgentToolset.__init__` now raises `ValueError` on a
non-`None` `timeout` and points the author at the members.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
